Implement .log to log map property changes
#53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you line up the values?
…Sent from my iPhone
On Oct 17, 2017, at 5:43 PM, Manuel Mujica ***@***.***> wrote:
This is how .log would be implemented based on the changes made to can-event-queue
Example output:
You can view, comment on, or merge this pull request online at:
#53
Commit Summary
Implement `.log` to log map property changes
File Changes
M can-simple-map.js (50)
M can-simple-map_test.js (63)
M package.json (3)
Patch Links:
https://github.com/canjs/can-simple-map/pull/53.patch
https://github.com/canjs/can-simple-map/pull/53.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Add a space after ‘is’
…Sent from my iPhone
On Oct 17, 2017, at 5:43 PM, Manuel Mujica ***@***.***> wrote:
This is how .log would be implemented based on the changes made to can-event-queue
Example output:
You can view, comment on, or merge this pull request online at:
#53
Commit Summary
Implement `.log` to log map property changes
File Changes
M can-simple-map.js (50)
M can-simple-map_test.js (63)
M package.json (3)
Patch Links:
https://github.com/canjs/can-simple-map/pull/53.patch
https://github.com/canjs/can-simple-map/pull/53.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Sure thing,
looking pretty now. |
m-mujica
force-pushed
the
log
branch
2 times, most recently
from
e467a79 to
7372f66
Compare
|
@justinbmeyer I changed this so it does not rely on the changes of There is only two places where QUESTION: do I need a |
m-mujica
commented
Oct 19, 2017
| }; | ||
|
|
||
| var meta = ensureMeta(this); | ||
| meta.allowedLogKeysSet = meta.allowedLogKeysSet || new Set(); |
There was a problem hiding this comment.
Do I need to polyfill Set for older browsers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example output: