#32 - Update either-or
#46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alfredo-Delgado
commented
Jul 31, 2017
can-stache-converters.js
Outdated
| get: function(chosen, a, b){ | ||
| return b !== chosen(); | ||
| get: function(chosen, a){ | ||
| return a === chosen(); |
There was a problem hiding this comment.
I think it's important to change this, now. Without this change, the case where chosen() doesn't match a or b results in a checked checkbox without the chosen value being updated to a or b.
There was a problem hiding this comment.
I'd suggest we even take it a step further and set chosen(b) if chosen() !== a.
Alfredo-Delgado
force-pushed
the
32-either-or
branch
from
3b88018 to
728ce9c
Compare
Alfredo-Delgado
changed the title
either-or and make false the default state…either-or
Alfredo-Delgado
force-pushed
the
32-either-or
branch
2 times, most recently
from
2b525cb to
14cc828
Compare
Alfredo-Delgado
commented
Aug 2, 2017
| QUnit.equal(map.pref, "Yes", "map updated because check was checked"); | ||
| }); | ||
|
|
||
| QUnit.test("supports computes", function() { |
There was a problem hiding this comment.
@justinbmeyer I added this test using computes. Does this answer your question?
Alfredo-Delgado
force-pushed
the
32-either-or
branch
from
14cc828 to
efb1c34
Compare
phillipskevin
approved these changes
Aug 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
undefinedand dev.warn in console if neitheraorbmatch~chosenResolves #32