Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call expressions whose this changes are not updated #616

Closed
justinbmeyer opened this issue Oct 24, 2018 · 2 comments
Closed

Call expressions whose this changes are not updated #616

justinbmeyer opened this issue Oct 24, 2018 · 2 comments
Labels

Comments

@justinbmeyer
Copy link
Contributor

justinbmeyer commented Oct 24, 2018

Something like: {{ this.todo.isSaving() }}

Doesn't work if this.todo is updated but the same .isSaving method exists on both.

Example: https://codepen.io/justinbmeyer/pen/ReeLaq?editors=1010

@justinbmeyer justinbmeyer changed the title bug with can-stache? Call expressions whose this changes are not updated Oct 24, 2018
@matthewp
Copy link
Contributor

Shouldn't the whole expression re-evaluate in this case?

@justinbmeyer
Copy link
Contributor Author

justinbmeyer commented Oct 24, 2018

@matthewp well, it depends on what "whole expression" means ...

a.outerCall( b.innerCall( c.superInner( arg1) ) ) 

If a changed in a.outerCall, we should not re-evaluate any of b.innerCall( c.superInner( arg1) ).

justinbmeyer added a commit that referenced this issue Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants