Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tests for IE11 #23

Merged
merged 2 commits into from
Oct 29, 2018
Merged

fix tests for IE11 #23

merged 2 commits into from
Oct 29, 2018

Conversation

cherifGsoul
Copy link
Member

Skip a test checks for function name property

Copy link

@phillipskevin phillipskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just feature detect once by putting something like this at the top of the module

var supportsFunctionNames = (function() {
  var fn = function() {};
  return !!fn.name;
}());

and then wrap the whole test in

if (supportsFunctionNames) {
  onlyDevTest("from method returns an observation with a helpful name", function() {
    // ...
  });
}

@cherifGsoul cherifGsoul merged commit f90f0b0 into master Oct 29, 2018
@cherifGsoul cherifGsoul deleted the ie11-compat branch October 29, 2018 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants