Add note for caveat when using elements other than script tags #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipskevin
requested changes
Nov 15, 2017
autorender.md
Outdated
| @@ -23,6 +23,7 @@ As long is this module is part of your CanJS build or imported with RequireJS, S | |||
| [can/view/autorender.can-autorender] will automatically look for `can-autorender` tags and render them. Once | |||
| all templates have finished rendering, it will call any callbacks passed to `can.autorender()`. | |||
|
|
|||
| Note: Although `auto-render` works on all HTML elements, using elements other than `script` tags will result in all attribute names being lowercased by the browser. This can cause `can-stache-bindings` to not work properly, so you should use `<script>` tags if your autorender content contains bindings. | |||
There was a problem hiding this comment.
auto-render -> can-autorender
phillipskevin
approved these changes
Nov 16, 2017
|
@imaustink can you merge/release this? |
|
@phillipskevin done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #70