Fix issue with edge for double insert #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inner element was being rendered twice, renderTagsInDocument was calling renderNodeAndChildren which was recursively mounting elements, and then mutation observer was adding it again
Improved the tagHandler to consolidate the check to see if the element has already been rendered
Mattchewone
force-pushed
the
105-bug-in-edge-double-insert
branch
from
3f39421 to
43639f6
Compare
|
Nice fix, I see my legend component isn't rendering four times anymore when trying this code. |
.. to the tagHandler function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inner element was being rendered twice, renderTagsInDocument was calling renderNodeAndChildren which was recursively mounting elements, and then mutation observer was adding it again.
Closes: #105