Merge pull request #110 from canjs/add-line-number-observable-blacklist

Added lineNumber to observable blacklist
canjs · Oct 26, 2017 · 94afa58 · 94afa58
2 parents e36e87d + 3a28619
commit 94afa58
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/template-context.js b/template-context.js
@@ -15,7 +15,8 @@ var nonObservableVars = {
 	element: true,
 	event: true,
 	viewModel: true,
-	arguments: true
+	arguments: true,
+	lineNumber: true
 };
 
 var getKeyAndParent = function(parent, key) {

diff --git a/test/scope-test.js b/test/scope-test.js
@@ -801,3 +801,18 @@ QUnit.test("scope.arguments should not be observable", function() {
 	canReflect.setKeyValue(templateContext, 'arguments', 1);
 	QUnit.equal( canReflect.getKeyValue(templateContext, 'arguments'), '1', '1');
 });
+
+QUnit.test("scope.lineNumber should not be observable", function() {
+	var scope = new Scope();
+	var templateContext = scope.getTemplateContext()._context;
+
+	canReflect.setKeyValue(templateContext, 'lineNumber', 0);
+	QUnit.equal( canReflect.getKeyValue(templateContext, 'lineNumber'), '0', '0');
+
+	canReflect.onKeyValue(templateContext, 'lineNumber', function(newVal) {
+		QUnit.ok(false, 'onKeyValue should not be fired');
+	});
+
+	canReflect.setKeyValue(templateContext, 'lineNumber', 1);
+	QUnit.equal( canReflect.getKeyValue(templateContext, 'lineNumber'), '1', '1');
+});