Refactoring templateContext #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipskevin
force-pushed
the
refactor-template-context
branch
from
3a11de6 to
cb4074f
Compare
phillipskevin
force-pushed
the
refactor-template-context
branch
from
7513c24 to
46af7ea
Compare
phillipskevin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make canjs/can-stache#359 work, we need to be able to read some properties on
scopedifferently than others (index,key, etc).This PR makes it so that reading
scopeactually give the scope,scope.varsreads fromscope.vars, and otherscope.properties read directly off ofscope.It also makes it so that there are now "special" contexts (
{ special: true }) andindexandkeyare read only from those special contexts.cc @imaustink