Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dev code for webpack compatibility #177

Merged
merged 2 commits into from
Jun 27, 2018
Merged

Conversation

cherifGsoul
Copy link
Member

This fixes the first part of this issue canjs/canjs#4170 to remove debug code from the production builds.


//!steal-remove-start
if (process.env.NODE_ENV !== 'production') {
scopeKeyDataPrototype[canSymbol.for("can.getName")] = function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the canSymbol.for() here is not needed (and might cause it not to work, I'm not sure), because this is already being passed into canReflect.assignSymbols()

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update to remove the use of canSymbol.for() when not needed.

@matthewp matthewp merged commit e1b7e3d into master Jun 27, 2018
@matthewp matthewp deleted the fix-webpack-debug-style branch June 27, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants