Set can-observation._value instead of .value #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillipskevin
approved these changes
Jul 3, 2018
chasenlehara
added a commit
to canjs/can-observation
that referenced
this pull request
Jul 3, 2018
This adds `_value` to every observation instance so it can be checked in packages that need to set the value directly. This is really a hack for canjs/can-compute#138 and canjs/can-view-scope#179
can-observation’s value property is going to be a getter, so now the `._value` property needs to be used. Related to canjs/can-observation#135
chasenlehara
force-pushed
the
can-observation-value
branch
from
3efb5eb to
11d3cdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
can-observation’s value property is going to be a getter, so now the
._valueproperty needs to be used.Related to canjs/can-observation#135