Remove clondeNode IE8 workaround #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewp
reviewed
May 29, 2019
|
|
||
| return copy; | ||
| }; | ||
| var cloneNode = function(el){ |
There was a problem hiding this comment.
Can we remove this function and just call el.cloneNode(true) wherever this function is currently used?
There was a problem hiding this comment.
Yeah, but what if this
can-view-target/can-view-target.js
Line 289 in d20dab3
There was a problem hiding this comment.
Sorry, I didn't see that it was being exported. For that reason I think we should keep it in for backwards compatibility. Sorry for overlooking that.
There was a problem hiding this comment.
@matthewp it is fixed!
There was a problem hiding this comment.
Thanks, looks good to me then.
cherifGsoul
force-pushed
the
i65-remove-ie8-cloneNode
branch
from
e67c7e4 to
23bd5d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clondeNodefunction needed for IE8clonesWorkfunctionFixes #65