New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent results when extending parsed can.Models #1272

Closed
alexkrautmann opened this Issue Oct 14, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@alexkrautmann

alexkrautmann commented Oct 14, 2014

I've noticed the following issues when extending a can.Model:

  • When a parent Model defines can.Model.models, a child Model.findAll calls the success callback with a undefined list
  • When a parent Model defines can.Model.parseModel, a child Model.findAll calls the success callback with a list of unparsed model objects
  • When a parent Model defines can.Model.parseModels, a child Model.findAll calls the error callback with Error: Could not get any raw data while converting using .models

This seems similiar to #1246

Fiddle here.

@daffl

This comment has been minimized.

Show comment
Hide comment
@daffl

daffl Oct 22, 2014

Contributor

It also looks like it is a regression. When I tested it, things worked in 2.1.3.

Contributor

daffl commented Oct 22, 2014

It also looks like it is a regression. When I tested it, things worked in 2.1.3.

@daffl daffl added this to the 2.1.4 milestone Oct 22, 2014

@alexkrautmann

This comment has been minimized.

Show comment
Hide comment
@alexkrautmann

alexkrautmann Oct 24, 2014

Hi daffl-

It might be important to note that all of these unexpected issues happen when findAll is defined in the parent models. This can be seen in the fiddle, but I didn't call it out in the original issue post.

alexkrautmann commented Oct 24, 2014

Hi daffl-

It might be important to note that all of these unexpected issues happen when findAll is defined in the parent models. This can be seen in the fiddle, but I didn't call it out in the original issue post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment