Fixed incorrect scope for can/event's delegate and undelegate #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daffl
added a commit
that referenced
this pull request
Jun 10, 2014
Fixed incorrect scope for can/event's delegate and undelegate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
delegateandundelegatealiases incan/eventare intended to provide fallbacks tobindandunbindfunctionality for normal JS objects. There was a bug where the scope was never passed when using those methods. #1039The existing test was incorrectly using
can/util'sdelegateandundelegate, notcan/events's. This fixes the test to properly test againstcan/event, as well as fixes the scope bug.