New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect scope for can/event's delegate and undelegate #1055

Merged
merged 1 commit into from Jun 10, 2014

Conversation

Projects
None yet
2 participants
@andykant
Contributor

andykant commented Jun 6, 2014

The delegate and undelegate aliases in can/event are intended to provide fallbacks to bind and unbind functionality for normal JS objects. There was a bug where the scope was never passed when using those methods. #1039

The existing test was incorrectly using can/util's delegate and undelegate, not can/events's. This fixes the test to properly test against can/event, as well as fixes the scope bug.

@andykant andykant added this to the 2.1.2 milestone Jun 6, 2014

daffl added a commit that referenced this pull request Jun 10, 2014

Merge pull request #1055 from bitovi/event-delegate-scope
Fixed incorrect scope for can/event's delegate and undelegate

@daffl daffl merged commit 1e23c6a into master Jun 10, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@daffl daffl deleted the event-delegate-scope branch Jun 10, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment