Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update docs #18

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Update docs #18

merged 2 commits into from
Oct 6, 2023

Conversation

nsklikas
Copy link
Contributor

@nsklikas nsklikas commented Oct 2, 2023

No description provided.

@nsklikas nsklikas requested review from a team and tmihoc October 2, 2023 12:41
bencekov
bencekov previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@bencekov bencekov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tmihoc
tmihoc reviewed Oct 5, 2023
View reviewed changes
Copy link
Member

@tmihoc tmihoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't have the time to look exhaustively. Just some suggestions.

DOCS/canonical-identity-platform-how-to-integrate-with-oidc-compatible-charms.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-integrate-with-oidc-compatible-charms.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-manage-external-identity-providers.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-manage-external-identity-providers.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-manage-external-identity-providers.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-manage-external-identity-providers.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
@nsklikas nsklikas mentioned this pull request Oct 5, 2023
Open
@nsklikas nsklikas requested review from bencekov and tmihoc October 5, 2023 13:40
tmihoc
tmihoc suggested changes Oct 5, 2023
View reviewed changes
DOCS/canonical-identity-platform-how-to-manage-external-identity-providers.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-manage-external-identity-providers.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-manage-external-identity-providers.md Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-integrate-with-oidc-compatible-charms.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-manage-external-identity-providers.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
@nsklikas nsklikas force-pushed the update-docs branch 5 times, most recently from 9e88fc4 to 8e57a54 Compare October 6, 2023 10:07
@nsklikas nsklikas requested a review from tmihoc October 6, 2023 10:07
@nsklikas nsklikas enabled auto-merge October 6, 2023 10:28
tmihoc
tmihoc approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@tmihoc tmihoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple more small things. I'll approve for now and leave it up to you whether to fix them right away or later.

DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-how-to-integrate-with-oidc-compatible-charms.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
DOCS/canonical-identity-platform-tutorial-deploy-identity-bundle.md Outdated Show resolved Hide resolved
@nsklikas nsklikas merged commit 71b92f5 into main Oct 6, 2023
@nsklikas nsklikas deleted the update-docs branch October 6, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmihoc tmihoc tmihoc approved these changes

@shipperizer shipperizer shipperizer approved these changes

@bencekov bencekov Awaiting requested review from bencekov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nsklikas @shipperizer @tmihoc @bencekov