Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2438] JupyterLab Spark integration #43

Merged
merged 10 commits into from
Oct 4, 2023
Merged

[DPE-2438] JupyterLab Spark integration #43

merged 10 commits into from
Oct 4, 2023

Conversation

deusebio
Copy link
Contributor

@deusebio deusebio commented Sep 28, 2023 •
edited
Loading

Works the same way but with JupyterLab instead of Notebook, which also seems a bit better as UX

@deusebio deusebio changed the base branch from dpe-2438-jupyter to 3.4-22.04/edge September 28, 2023 15:27
@deusebio deusebio changed the title [DPE-2438] Switching to JupyterLab [DPE-2438] JupyterLab Spark integration Sep 28, 2023
welpaolo
welpaolo approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@welpaolo welpaolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I just left a couple of minor comments

tests/integration/resources/jupyter.yaml Outdated Show resolved Hide resolved
grobbie
grobbie reviewed Oct 2, 2023
View reviewed changes
Copy link

@grobbie grobbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

open question on the --allow-root flag

rockcraft.yaml Outdated Show resolved Hide resolved
@deusebio
Copy link
Contributor Author

deusebio commented Oct 2, 2023

I have addressed the comments and rebase the branch. It should be ready for re-review

@deusebio deusebio mentioned this pull request Oct 2, 2023
Closed
grobbie
grobbie approved these changes Oct 4, 2023
View reviewed changes
Copy link

@grobbie grobbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 👍

@deusebio deusebio merged commit 55b1279 into canonical:3.4-22.04/edge Oct 4, 2023
3 checks passed
@deusebio deusebio deleted the dpe-2438-jupyterlab branch October 4, 2023 13:24
@kimwnasptd kimwnasptd mentioned this pull request Oct 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grobbie grobbie grobbie approved these changes

@welpaolo welpaolo welpaolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deusebio @welpaolo @grobbie