BugFix for docker/save-and-load remove image before try to load it again (BugFix) #2018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com>
locnnil
changed the title
locnnil
changed the title
locnnil
changed the title
|
Hello, thanks for this, please provide at least a submission to prove this works |
Hook25
added
the
waiting-for-changes
- fix: stop using I/O redirection
During docker save command, the `ubuntu.tar` file saved was actually an
empty file. After changing the save operation to use `-i` the test still failing.
Then after changing the load operation to not use the redirection it worked.
- feat: Prune image before load back
Delete all image layers before trying to load
Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com>
|
@Hook25 At first when I tried to run with my change it didn't work. Then I revert it, but still, it doesn't work. After investigating, I saw that the IO redirection for the save and load command weren't working inside Checkbox. Outside it works fine. So I changed the method to use to save and load the tarball, and now the tests passes. Here is the requested submission: |
|
Interesting, it is really weird that it doesn't work inside of Checkbox that command, it looks good to me. Either way, thanks for fixing it. |
Hook25
approved these changes
Aug 11, 2025
bladernr
pushed a commit
that referenced
this pull request
Aug 28, 2025
…ain (BugFix) (#2018) * Fix(docker/save-and-load): remove image before try to load it again Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com> * fix: I/O redirection operators not working for docker save and load - fix: stop using I/O redirection During docker save command, the `ubuntu.tar` file saved was actually an empty file. After changing the save operation to use `-i` the test still failing. Then after changing the load operation to not use the redirection it worked. - feat: Prune image before load back Delete all image layers before trying to load Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com> --------- Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com>
stanley31huang
pushed a commit
that referenced
this pull request
Oct 3, 2025
…ain (BugFix) (#2018) * Fix(docker/save-and-load): remove image before try to load it again Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com> * fix: I/O redirection operators not working for docker save and load - fix: stop using I/O redirection During docker save command, the `ubuntu.tar` file saved was actually an empty file. After changing the save operation to use `-i` the test still failing. Then after changing the load operation to not use the redirection it worked. - feat: Prune image before load back Delete all image layers before trying to load Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com> --------- Signed-off-by: Lincoln Wallace <lincoln.wallace@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test has an inconsistency, it saves an image get from docker hub on a tar file and immediately tries to load it back, which doesn't make sense because this operation will be cached/ignored.
This adds a removal of the image before trying to load the tar file.
Documentation
Tests