Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IAM 1012 #69

Merged
merged 3 commits into from
Aug 30, 2024
Merged

IAM 1012 #69

merged 3 commits into from
Aug 30, 2024

Conversation

shipperizer
Copy link
Contributor

@shipperizer shipperizer commented Aug 29, 2024 •
edited
Loading

  • fix: WIP tweak v0 cert-transfer lib to allow multiple versions of the same interface
  • fix: WIP tweak v1 cert-transfer lib to allow multiple versions of the same interface
  • feat: allow v0 and v1 cert transfer requirers
  • build: add pydantic dependency

@shipperizer shipperizer requested a review from a team as a code owner August 29, 2024 11:59
@shipperizer shipperizer force-pushed the IAM-1012 branch 2 times, most recently from 433bd40 to 05f388f Compare August 29, 2024 13:10
@shipperizer shipperizer self-assigned this Aug 29, 2024
@shipperizer shipperizer added help wanted Extra attention is needed invalid This doesn't seem right labels Aug 29, 2024
@shipperizer
Copy link
Contributor Author

@nsklikas @natalian98 please let's discuss in here how we can overcome the issue of the double relation with different versions

we might need to drop v0 (and not support self-signed-certificates) until support is added

nsklikas
nsklikas reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@nsklikas nsklikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can undo the changes to v0 and ditch it altogether as we handle the databag on our own

src/integrations.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
lib/charms/certificate_transfer_interface/v0/certificate_transfer.py Outdated Show resolved Hide resolved
src/charm.py Outdated Show resolved Hide resolved
src/integrations.py Outdated Show resolved Hide resolved
wood-push-melon
wood-push-melon reviewed Aug 29, 2024
View reviewed changes
src/charm.py Outdated Show resolved Hide resolved
@shipperizer shipperizer removed help wanted Extra attention is needed invalid This doesn't seem right labels Aug 30, 2024
@shipperizer shipperizer merged commit f2af047 into main Aug 30, 2024
3 checks passed
@shipperizer shipperizer deleted the IAM-1012 branch August 30, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wood-push-melon wood-push-melon wood-push-melon left review comments

@nsklikas nsklikas nsklikas approved these changes

Assignees

@shipperizer shipperizer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shipperizer @nsklikas @wood-push-melon