Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the frig #3369

Merged
merged 2 commits into from
May 14, 2024
Merged

Revert the frig #3369

merged 2 commits into from
May 14, 2024

Conversation

AlanGriffiths
Copy link
Contributor

Test allowing remote-builds

@AlanGriffiths AlanGriffiths requested a review from a team as a code owner May 3, 2024 13:15
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.52%. Comparing base (63ef89c) to head (f4b57b3).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3369      +/-   ##
==========================================
- Coverage   77.52%   77.52%   -0.01%     
==========================================
  Files        1075     1065      -10     
  Lines       68300    67901     -399     
==========================================
- Hits        52949    52637     -312     
+ Misses      15351    15264      -87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from mir-libs-for-22-and-24 to main May 3, 2024 14:36
@AlanGriffiths AlanGriffiths force-pushed the revert-the-frig branch 2 times, most recently from 0df84eb to f50ea3a Compare May 7, 2024 10:29
@AlanGriffiths
Copy link
Contributor Author

@Saviq I think this is good to go: the test tools and frame failures look like they need fixing in those projects?

Copy link
Collaborator

@Saviq Saviq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yups.

@AlanGriffiths AlanGriffiths added this pull request to the merge queue May 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 14, 2024
@AlanGriffiths AlanGriffiths added this pull request to the merge queue May 14, 2024
Merged via the queue into main with commit 943b976 May 14, 2024
34 of 36 checks passed
@AlanGriffiths AlanGriffiths deleted the revert-the-frig branch May 14, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants