Switched to Loki log forwarding.

[pik4ez-canonical]

IAM-1029

Closes #97

[BarcoMasile]

Great job!

[nsklikas]

Good job, LGTM to me overall. I have a couple of small comments, once those are addressed and if you have manually tested it, we can merge it

[pik4ez-canonical]

Thank you Marco and Nikos for your reviews. I made changes based on your feedback.

The only thing that's left and that's actually important is that alert rules aren't propagated to Loki and Grafana when using LogForwarder. The problem is in the logging library, see issue.

Nikos suggested to contact Observability team. But what would be your advice for this PR?

[BarcoMasile]

Thank you Marco and Nikos for your reviews. I made changes based on your feedback.

The only thing that's left and that's actually important is that alert rules aren't propagated to Loki and Grafana when using LogForwarder. The problem is in the logging library, see issue.

Nikos suggested to contact Observability team. But what would be your advice for this PR?

@pik4ez-canonical I'd go with contacting the Obs team right away :)
But also, take a look at this as suggested by one commenter in that issue

[nsklikas]

Thank you Marco and Nikos for your reviews. I made changes based on your feedback.
The only thing that's left and that's actually important is that alert rules aren't propagated to Loki and Grafana when using LogForwarder. The problem is in the logging library, see issue.
Nikos suggested to contact Observability team. But what would be your advice for this PR?

@pik4ez-canonical I'd go with contacting the Obs team right away :) But also, take a look at this as suggested by one commenter in that issue

The problem is that the library does not call that function, unfortunately the only thing we can do is something like this:

diff --git a/src/charm.py b/src/charm.py
index 8603562..f74aa04 100755
--- a/src/charm.py
+++ b/src/charm.py
@@ -43,6 +43,7 @@ from ops import (
     HookEvent,
     LeaderElectedEvent,
     PebbleReadyEvent,
+    RelationEvent,
     StartEvent,
     StopEvent,
     UpdateStatusEvent,
@@ -108,6 +109,11 @@ class OpenFGAOperatorCharm(CharmBase):
 
         # Loki logging relation
         self._log_forwarder = LogForwarder(self, relation_name=LOG_PROXY_RELATION_NAME)
+        # Workaround for https://github.com/canonical/loki-k8s-operator/issues/403
+        # TODO: Remove when the issue is fixed
+        self.framework.observe(self.on[LOG_PROXY_RELATION_NAME].relation_created, self._push_loki_alert_rules)
+        self.framework.observe(self.on[LOG_PROXY_RELATION_NAME].relation_changed, self._push_loki_alert_rules)
+        self.framework.observe(self.on[LOG_PROXY_RELATION_NAME].relation_departed, self._push_loki_alert_rules)
 
         # Prometheus metrics endpoint relation
         self.metrics_endpoint = MetricsEndpointProvider(
@@ -215,6 +221,9 @@ class OpenFGAOperatorCharm(CharmBase):
             "database_name": DATABASE_NAME,
         }
 
+    def _push_loki_alert_rules(self, event: RelationEvent) -> None:
+        self._log_forwarder._handle_alert_rules(event.relation)
+
     @property
     def _log_level(self) -> str:
         return self.config["log-level"]

But we will have to be mindful, so that when (if) the issue is fixed, we remove this.

[nsklikas]

Great job

[sed-i]

Hi team,
Thanks for the reference, fixed in loki too, and available in LIBPATCH=13.