[DPE-8426] port tests #1206
Draft
[DPE-8426] port tests #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
added
the
not bug or enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (64.57%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1206 +/- ##
========================================
Coverage 64.57% 64.57%
========================================
Files 17 17
Lines 4344 4344
Branches 671 671
========================================
Hits 2805 2805
Misses 1357 1357
Partials 182 182 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
force-pushed
the
dpe-8426-port-tests
branch
from
98cb060 to
85ae99f
Compare
dragomirp
force-pushed
the
dpe-8426-port-tests
branch
from
85ae99f to
76fe647
Compare
dragomirp
commented
Oct 7, 2025
| password: str, | ||
| queries: list[str], | ||
| database: str, | ||
| commit: bool = False, |
There was a problem hiding this comment.
Diff: Raw not available for PG.
dragomirp
commented
Oct 7, 2025
Comment on lines
+1461
to
+1464
| psycopg2.connect( | ||
| f"dbname='{database}' user='{username}' host='{unit_address}' password='{password}' connect_timeout=10" | ||
| ) as connection, | ||
| connection.cursor() as cursor, |
There was a problem hiding this comment.
Diff: Getting a cursor is different for psycopg2.
dragomirp
commented
Oct 7, 2025
| import subprocess | ||
| from collections.abc import Callable | ||
|
|
||
| import jubilant |
There was a problem hiding this comment.
Diff: Using jubilant, since PG 16 does not need Juju 2 support.
dragomirp
commented
Oct 7, 2025
|
|
||
| # Simulating a failure on the primary cluster | ||
| for unit_name in model_2_postgresql_units: | ||
| model_2.exec("sudo pkill -x postgres --signal SIGSTOP", unit=unit_name) |
There was a problem hiding this comment.
Diff: DB process name. No check for Patroni.
dragomirp
commented
Oct 7, 2025
| charm=charm, | ||
| app=POSTGRESQL_APP_1, | ||
| base="ubuntu@22.04", | ||
| config=configuration, |
There was a problem hiding this comment.
Diff: No cluster name in PG.
dragomirp
force-pushed
the
dpe-8426-port-tests
branch
2 times, most recently
from
eff6861 to
744dd63
Compare
dragomirp
force-pushed
the
dpe-8426-port-tests
branch
from
744dd63 to
1eb046e
Compare
dragomirp
force-pushed
the
dpe-8426-port-tests
branch
from
9fa9066 to
c35a605
Compare
dragomirp
force-pushed
the
dpe-8426-port-tests
branch
from
8eaec8a to
731f8b9
Compare
dragomirp
force-pushed
the
dpe-8426-port-tests
branch
from
21cf8ad to
fa8c884
Compare
dragomirp
force-pushed
the
dpe-8426-port-tests
branch
from
a61fbe3 to
e22958c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Checklist