-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix execution times in lxd 3.0.1 and add pipelining support to execute #321
Conversation
7ac870b
to
e4e4913
Compare
Codecov Report
@@ Coverage Diff @@
## master #321 +/- ##
==========================================
- Coverage 96.84% 96.84% -0.01%
==========================================
Files 11 11
Lines 920 918 -2
Branches 106 106
==========================================
- Hits 891 889 -2
Misses 10 10
Partials 19 19
Continue to review full report at Codecov.
|
258e377
to
c6f5ab5
Compare
Thanks for putting this together. However, there seems to be something very odd going on with the PR as it includes a bunch of already committed patches? Perhaps you need a git fetch/merge and/or rebase from this master to only submit the PR that is relevant to this change? I'll do some testing with the branch/commit from your repo as well. Thanks very much. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebasing (I think) as it has many already committed changes in the PR.
Signed-off-by: lasizoillo <lasizoillo@gmail.com>
c6f5ab5
to
b5feace
Compare
Rebased |
@ajkavanagh Can you please review this? Have been waiting on a fix for this for a while. |
@Silentphantom62 and @lasizoillo -- sorry for the delay; just got back from holiday -- I'll review & do some integration tests today. |
Okay, I've tested this in 1604 and 1804 hosts and containers, and everything seems to work great. Thanks very much for the PR, and sorry for the delay in getting it merged. |
Thanks @ajkavanagh what's the tentative release date of this fix? |
Fix issue #316 and issue #244
It works (tox and integration tests) with lxd versions 3.0.1 and 2.0.11
Can be tested with this script to view some new features:
container.execute
is retro-compatible but adds pipeline features. Now you can communicate with your commands via stdin and manage output while command is executing.