Fix race condition in 2.2.8 generating long pauses #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lasizoillo <lasizoillo@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #337 +/- ##
==========================================
+ Coverage 96.84% 96.84% +<.01%
==========================================
Files 11 11
Lines 918 919 +1
Branches 106 106
==========================================
+ Hits 889 890 +1
Misses 10 10
Partials 19 19
Continue to review full report at Codecov.
|
ajkavanagh
approved these changes
Nov 22, 2018
|
Note that this may provide a fix for #336 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: lasizoillo lasizoillo@gmail.com
LXD sends TextMessage frames until the last one, then send a BinaryMessage and closes connection. If connection is closed no read events can't arrive to EPollPoller and ws4py doesn't read more data. But ws4py get into a loop in some cases waiting for streaming data to complete a message frame. There are another infinite loop waiting to ws4py to drain connection buffer.
I hope this fix resolve all corner cases. If not, I hope be more free to fix it sooner.