Fix dropped timeout in pylxd/client.py #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When constructing the call, the [next-part] method creates the next element in the chain of /part/<nextpart>. However, it doesn't pass through the timeout parameter which means that it doesn't end up on the final call. This patch fixes that. Signed-off-by: Alex Kavanagh <alex.kavanagh@canonical.com>
Codecov Report
@@ Coverage Diff @@
## master #359 +/- ##
=======================================
Coverage 96.92% 96.92%
=======================================
Files 12 12
Lines 1008 1008
Branches 113 113
=======================================
Hits 977 977
Misses 12 12
Partials 19 19
Continue to review full report at Codecov.
|
ChrisMacNaughton
approved these changes
May 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing the call, the [next-part] method creates the next
element in the chain of /part/. However, it doesn't pass
through the timeout parameter which means that it doesn't end up on the
final call. This patch fixes that.
Signed-off-by: Alex Kavanagh alex.kavanagh@canonical.com