Fix execute command missing output with pauses in output text #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the container execute command, if the command executed has pauses in the output text, the websocket will send binary messages. These were interpreted as the stream being completed, and pylxd closed the websocket, thus losing the rest of the output. Delving into the code indicated some very strange behaviour across the threads, so as part of solving the problem, this has been cleaned up as well. Closes: canonical#362 Signed-off-by: Alex Kavanagh <alex.kavanagh@canonical.com>
ajkavanagh
force-pushed
the
bug/362/ensure-all-output-on-execute
branch
from
8010a87
to
4c59b13
Compare
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
- Coverage 96.8% 96.44% -0.36%
==========================================
Files 12 12
Lines 1034 1042 +8
Branches 119 120 +1
==========================================
+ Hits 1001 1005 +4
- Misses 13 16 +3
- Partials 20 21 +1
Continue to review full report at Codecov.
|
ChrisMacNaughton
approved these changes
May 17, 2019
ajkavanagh
added a commit
to ajkavanagh/pylxd
that referenced
this pull request
May 17, 2019
Essentially, the behavior changed for when a caller to the container's execute method wished to handle the packets received back on the websocket. This change fixes the reversion. Signed-off-by: Alex Kavanagh <alex.kavanagh@canonical.com>
ChrisMacNaughton
added a commit
that referenced
this pull request
May 20, 2019
Fix change of behaviour on execute introduced in #363
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the container execute command, if the command executed has pauses in
the output text, the websocket will send binary messages. These were
interpreted as the stream being completed, and pylxd closed the
websocket, thus losing the rest of the output.
Delving into the code indicated some very strange behaviour across the
threads, so as part of solving the problem, this has been cleaned up as
well.
Closes: #362