Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tox target to typecheck via mypy #456

Merged
merged 1 commit into from
Jan 18, 2021
Merged

add tox target to typecheck via mypy #456

merged 1 commit into from
Jan 18, 2021

Conversation

albertodonato
Copy link
Contributor

The plan is to start adding type checks and verify them via mypy.

Also cleanup a bunch of mocck imports to import via unittest module.

Signed-off-by: Alberto Donato alberto.donato@canonical.com

The plan is to start adding type checks and verify them via mypy.

Also cleanup a bunch of mocck imports to import via unittest module.

Signed-off-by: Alberto Donato <alberto.donato@canonical.com>
Copy link
Contributor

@sparkiegeek sparkiegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@albertodonato albertodonato merged commit 16da44e into canonical:master Jan 18, 2021
@albertodonato albertodonato deleted the add-typecheck-target branch January 18, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants