whilst should allow an asynchronous test function

[brianmaissy]

It would be useful (to me at least) if whilst could optionally accept an asynchronous test function. It would work by delegating to the normal whilst, just storing local state about the last outcome of the test. Something like this:

whilst: function(test, action, callback){
    if(test.length > 0) newWhilst(test, action, callback)
    else {
        ...
    }
},

newWhilst: function(test, action, callback){
    test(function(state){
       whilst(function(){
            return state;
        },
        function(callback){
            action(function(){
                test(function(result){
                    state = result;
                    callback();
                });
            });
        },
        callback);
    });
},

Is there a reason this feature isn't implemented? If not I'd be happy to add it and submit a pull request

[brianmaissy]

@caolan, just dug this up from a while ago. Thoughts?

[caolan]

I can see that it might be useful, but we run into the backwards-incompatibility or the function arity confusion again. I think depending on function arity in this circumstance is less troublesome than the map/each/etc. iterators though.

Any ideas on how else we might implement this?

[brianmaissy]

I agree that arity is not a huge issue here. What's the chances that someone would use a function that takes arguments as a predicate without giving it any?

But naming it differently is definitely not a bad idea, I like being safe. The first thing that comes to mind is whilstAsync, but it's a little awkward to suffix something in async with async. It could be confusing. We could clarify but make it slightly less pretty by calling it whilstAsyncCondition or whilstAsyncPredicate or something.

[alizbazar]

This message was created automatically by mail delivery software.

A message that you sent could not be delivered to one or more of its
recipients. This is a temporary error. The following address(es) deferred:

alizbazar@gmail.com
Domain alizweb.com has exceeded the max emails per hour (121/120 (100%)) allowed. Message will be reattempted later

------- This is a copy of the message, including all the headers. ------
Received: from github-smtp2-ext6.iad.github.net ([192.30.252.197]:40948 helo=github-smtp2b-ext-cp1-prd.iad.github.net)
by web107.webhotelli.fi with esmtps (TLSv1:DHE-RSA-AES256-SHA:256)
(Exim 4.82)
(envelope-from noreply@github.com)
id 1WTaN6-0003YF-6j
for alizbazar@alizweb.com; Fri, 28 Mar 2014 19:15:12 +0200
Date: Fri, 28 Mar 2014 10:15:11 -0700
From: Caolan McMahon notifications@github.com
Reply-To: caolan/async reply@reply.github.com
To: caolan/async async@noreply.github.com
Message-ID: caolan/async/issue/156/issue_event/106554023@github.com
In-Reply-To: caolan/async/issues/156@github.com
References: caolan/async/issues/156@github.com
Subject: Re: [async] whilst should allow an asynchronous test function (#156)
Mime-Version: 1.0
Content-Type: multipart/alternative;
boundary="--==_mimepart_5335ae1f2f880_5d903faee58212b0111131";
charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: list
X-GitHub-Recipient: alizbazar
List-ID: caolan/async <async.caolan.github.com>
List-Archive: https://github.com/caolan/async
List-Post: mailto:reply@reply.github.com
List-Unsubscribe: mailto:unsub+i-5953901-7c2ccfad2d786198d3f5ae7acc754a84d36cfd57-736771@reply.github.com,
https://github.com/notifications/unsubscribe/736771__eyJzY29wZSI6Ik5ld3NpZXM6TXV0ZSIsImV4cGlyZXMiOjE3MTE2NDYxMTEsImRhdGEiOnsiaWQiOjE1MjY4MjN9fQ==--f6cbaa771f3c3fa0aebf858fe5ece11c3f7b7a63
X-Auto-Response-Suppress: All
X-GitHub-Recipient-Address: alizbazar@alizweb.com

----==_mimepart_5335ae1f2f880_5d903faee58212b0111131
Content-Type: text/plain;
charset=UTF-8
Content-Transfer-Encoding: 7bit

Closed #156.

---

Reply to this email directly or view it on GitHub:
#156
----==_mimepart_5335ae1f2f880_5d903faee58212b0111131
Content-Type: text/html;
charset=UTF-8
Content-Transfer-Encoding: 7bit

Closed #156.

—
Reply to this email directly or view it on GitHub.

----==_mimepart_5335ae1f2f880_5d903faee58212b0111131--

[lookfirst]

I just noticed this issue was closed recently and I just ran into wanting this feature. Is there a workaround?

[aearly]

Submit a PR if you want the feature.

On Thu, Apr 3, 2014 at 11:24 AM, Jon Stevens notifications@github.comwrote:

I just noticed this issue was closed recently and I just ran into wanting
this feature. Is there a workaround?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/156#issuecomment-39486678
.

[lookfirst]

Nevermind, I just ended up using forever and a workaround there instead.