implement <name> and <name>Series with <name>Limit #847
Conversation
|
Cool! Have you run benchmark against master? ./perf/benchmark.js master |
| callback(null); | ||
| if (r.length >= a.length) { | ||
| if (done) { | ||
| test.same(r, a); |
There was a problem hiding this comment.
Whats the point of these changes
There was a problem hiding this comment.
Test fail without them. With how eachOfLimit is executed since the first iteration is synchronous, it executed the second iteration and so on so this causes multiple calls to test.done()
There was a problem hiding this comment.
Hmm, alright that's breaking and should be fixed in v2
There was a problem hiding this comment.
I've created a 2.x branch we could merge this PR into. Although, I'm a bit hesitant because it could set us up for merge hell if we end up making lots of changes on master.
|
.As one might expect, the results of running benchmark indicate a significant his (on the order of several ms in some cases) to parallel functions and a minor hit to series functions. I think this is fine for Benchmark results: https://gist.github.com/megawac/b5e4120f04f1c7712639 |
|
The parallel case doesn't look any better inside |
|
I'll look into this further over the weekend, but I'd be surprised if |
|
I do really like this direction though as it will make |
|
Master has change significantly with the modularization. We ready for this change, though. 👍 |
|
@aearly updated |
|
👍 after review. Feel free to merge alex if you're happy with it |
implement <name> and <name>Series with <name>Limit
|
I love seeing code changes that remove 60 lines of code without taking away functionality. 😄 |
@aearly @megawac
fixes #778
Ended up adding
concatLimitanddetectLimitin the process.Still need to add tests and documentation