[SNOW:DINC0374643] Adding a check for sdm roles while renaming attachments #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashmeet29
approved these changes
Jan 17, 2025
| if (responseCode == 403) { | ||
| // SDM Roles for user are missing | ||
| throw new ServiceException(SDMConstants.SDM_MISSING_ROLES_EXCEPTION_MSG, null); | ||
| } |
There was a problem hiding this comment.
can we also capture else condition so that if any other error we just throw Unable to rename due to an error at the server.
| cmisDocument); | ||
| if (responseCode == 403) { | ||
| // SDM Roles for user are missing | ||
| throw new ServiceException(SDMConstants.SDM_MISSING_ROLES_EXCEPTION_MSG, null); |
There was a problem hiding this comment.
same comment as above
rashmiangadi11
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a user is able to rename a file even if they do not have SDM roles.
Bug Link: https://itsm.services.sap/nav_to.do?uri=x_sapda_devinc_development_incident.do?sys_id=0c9d1540834f5e54e85fc230feaad3f4%26sysparm_view=Development_Incident
This PR is intended to resolve this issue and throw an error suggesting the user does not have sufficient permissions.