Remove oauth scope warning and redundant oauth scope #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When the Turing SDK is used to authenticate a user with a user account, the warning
Not all requested scopes were granted by the authorization server, missing scopes email.gets thrown because the scope specified for the email field was stated asemailinstead ofhttps://www.googleapis.com/auth/userinfo.email(see https://developers.google.com/identity/protocols/oauth2/scopes#oauth2 for more info).The relevant change has already been made in caraml-dev/caraml-sdk#3, and this PR makes a change to the version of
caraml-auth-googleto incorporate those changes. The unused constantOAUTH_SCOPEShas also been removed from the SDK in the process.Thanks @ariefrahmansyah for catching this!