feat(ui): Remove ticks and display min-max labels in EuiDualRange slider #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Similar to caraml-dev/merlin#546 whereby the min-max replica slider bar has been slightly modified by removing the ticks to better accommodate larger ranges (e.g. 100 replicas), this PR makes similar changes to the Turing UI in order to keep the design of the resource request components similar in both Turing and Merlin.
New design of the resource requests component
Notice how the min and max values are now displayed as labels at the ends of the slider bar.
Changes
ui/src/router/components/form/components/ResourcesPanel.js- Removal of ticks and addition of min-max labels