Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(svelte): make ref and chart props optional #1612

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Jul 7, 2023

Updates

  • Svelte charts were giving TypeScript warnings if the user didn't provide the ref or chart property (when they weren't needed). Added defaults for those properties in BaseChart.svelte which aligns better to 1.8.0.
  • Based on what we found yesterday with React, adjusted the destroy method of BaseChart.svelte (reset chart prop to null after destroying components but not the holder)
  • Added CSS class 'cds--chart-holder' to the chart holder to align Svelte behavior with core rendering.
  • Fixed issue where toolbar on Svelte charts was displaying vertically initially until resized
  • Added randomly generated HTML id to chart in case users need one (was in 1.8.0)
  • Republished essential types like ChartTabularData and options for each chart type so users won't need @carbon/charts dependency. Ditto for most commonly-used enums.
  • Updated vite-plugin-dts (just an update to the docs I contributed)
  • Vite bug fix (postcss related)
  • Updated @carbon/styles with sass marked as an optional peerDependency. Should allow us to drop sass from StackBlitz speeding up the loading (will test after next publish).
  • Bumped Angular to 16.1.4 (components work better with older @angular/router)

@nstuyvesant nstuyvesant requested review from theiliad, Akshat55 and a team as code owners July 7, 2023 15:25
@nstuyvesant nstuyvesant requested review from zvonimirfras and removed request for a team July 7, 2023 15:25
@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 22aa511
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/64a82e87900cf30008be288b
😎 Deploy Preview https://deploy-preview-1612--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 22aa511
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/64a82e87940f790008150a82
😎 Deploy Preview https://deploy-preview-1612--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 22aa511
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/64a82e87be12430008059199
😎 Deploy Preview https://deploy-preview-1612--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@theiliad theiliad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theiliad theiliad merged commit 624aa66 into carbon-design-system:master Jul 7, 2023
@theiliad theiliad deleted the svelte-ts-tweaks branch July 7, 2023 17:08
@theiliad theiliad added type: bug 🐛 Something isn't working package: svelte labels Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: svelte type: bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants