Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): Creation of new documentation website (PLEASE SQUASH COMMITS) #1798

Merged
merged 303 commits into from
Jun 26, 2024
Merged

feat(docs): Creation of new documentation website (PLEASE SQUASH COMMITS) #1798

merged 303 commits into from
Jun 26, 2024

Conversation

nstuyvesant
Copy link
Contributor

@nstuyvesant nstuyvesant commented Apr 26, 2024 •
edited
Loading

What is this?

  • Created a new @carbon/charts documentation site in React that replaces Storybooks.
  • Ripped out Storybook. These depended on a deprecated API (storiesOf).
  • Each package now has a test page that can be viewed via yarn dev from the package subdirectories
  • npx lerna run build:test builds the test pages in pages/test for each package
  • Fixed eslint and prettier across all packages
  • Fixed husky and set it to run eslint and prettier only on staged content (instead of entire monorepo)
  • Added DOM tests for all packages which can be run in parallel by yarn test:dom from the monorepo root (yarn test:dom:rebase rebuilds the baseline).

Demo screenshot or recording

image image image image

@nstuyvesant nstuyvesant requested review from theiliad and a team as code owners April 26, 2024 01:59
@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for carbon-charts-angular ready!

Name Link
🔨 Latest commit 8c6f3e0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-angular/deploys/667c4f8812e640000804ae4e
😎 Deploy Preview https://deploy-preview-1798--carbon-charts-angular.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for carbon-charts-react ready!

Name Link
🔨 Latest commit 8c6f3e0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-react/deploys/667c4f8822b1c10008331c9c
😎 Deploy Preview https://deploy-preview-1798--carbon-charts-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Apr 26, 2024 •
edited
Loading

✅ Deploy Preview for carbon-charts-core ready!

Name Link
🔨 Latest commit 8c6f3e0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-core/deploys/667c4f88fdbb930008e88aa5
😎 Deploy Preview https://deploy-preview-1798--carbon-charts-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nstuyvesant
fix(wordcloudoptions): across packages
7172580
@nstuyvesant
fix(docs): dupe property
6dc2dcd
@nstuyvesant
chore(deps): minor bumps for dependencies
e662bba
@nstuyvesant
feat(diagrams): add elbox and bezier examples
ca0a60d
@nstuyvesant
chore(deps): minor bumps
5d117cd
@nstuyvesant
chore(images): put in subfolders, fix indentation
46707ba
@nstuyvesant
fix(typescript): missing properties on options in core
02a8532
@nstuyvesant
chore(test data): consolidate examples for use by tests
5ccb453
@nstuyvesant
chore(cleanup): remove unused imports, blank lines
b63548f
@nstuyvesant
fix(typescript): another type issue identified in core
75fb07f
@nstuyvesant
test(docs): publish test data for other packages in the monorepo (in …
6b2bd24 
…pure TypeScript)
@nstuyvesant
fix(svelte): bar chart names for svelte are normalized
0614b88
@nstuyvesant
chore(types): provide all enums instead of just a limited set
60e10bf
@nstuyvesant
feat(svelte): create test page for when storybook is dropped
3f59059
@nstuyvesant
feat(test): harness for Vue.js
b91b45c
@nstuyvesant
feat(vue,vanilla js): test harnesses
3116f5d
@nstuyvesant
chore(angular): add charts dependency
23fcf1a
@nstuyvesant
chore(deps): bump @ibm/telemetry-js, @stackblitz/sdk, storybook, carb…
d2bb7a9 
…on-components, sass, svelte, vue
@nstuyvesant
feat(test): for react
a624bde
@nstuyvesant
chore(deps): bump @carbon/colors, layout, styles, themes, react, icon…
cdb0092 
…s-react
@nstuyvesant
chore(deps): bump yarn, dompurify, react-router-dom, @types/react, sa…
089a465 
…ss, vue-tsc, install missing Angular test packages
@nstuyvesant
chore(angular): add schematics to angular.json
a30a756
@nstuyvesant
fix(docs): typescript issues
6b2af4f
@nstuyvesant
fix(core): typescript issues exposed by type checking the demos
21b4526
@nstuyvesant
feat(angular): extremely large number of files needed by angular to d…
08cdcfe 
…o what svelte did in 15 lines of code
@netlify Netlify
Copy link

netlify bot commented Jun 26, 2024 •
edited
Loading

✅ Deploy Preview for carbon-charts-docs ready!

Name Link
🔨 Latest commit 8c6f3e0
🔍 Latest deploy log https://app.netlify.com/sites/carbon-charts-docs/deploys/667c4f88fdbb930008e88aaa
😎 Deploy Preview https://deploy-preview-1798--carbon-charts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

theiliad
theiliad approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@theiliad theiliad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a very large PR, so I've tried my best to review here. I would've like others to also participate here

@theiliad theiliad merged commit 9df518a into carbon-design-system:master Jun 26, 2024
6 checks passed
@theiliad theiliad deleted the docs branch June 26, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theiliad theiliad theiliad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nstuyvesant @theiliad