-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat($core): adds support for tension, beta, alpha in curves #81
feat($core): adds support for tension, beta, alpha in curves #81
Conversation
The idea to support the dual |
Deploy preview for kind-hypatia-c6b5c4 ready! Built with commit 09437dc |
I think we need to have a discussion here. There are 2 ways to do this: @t-mullen @zvonimirfras @cal-smith which approach looks more ideal to you? Aside from that the implementation works great, although I would suggest we throw a |
I think 2 overall ... it's a little more complex, but it does a better job of keeping everything localized. That said, does the rest of the library use |
@cal-smith I agree about approach number 2. Nope, usually we don't do |
Any updates here @t-mullen? |
API
The decided-upon API has been implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
@zvonimirfras @cal-smith ready to merge |
Adds support for D3 curve modification methods like tension, alpha and
beta. Re-done because of the broken Git forks.
Closes #39
Updates
.tension()
,.alpha()
,.beta()
, any any other similar methods).Demo screenshot or recording
The demo
curveNatural
has been replaced with thecurveCardinal
with a modified tension (it is visually identical.)Review checklist (for reviewers only)