-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package | Components architecture (VanillaJS/HTML) #224
Comments
On Jun 25, Jeff-Chew commented: |
On Jun 25, james-dow commented: |
On Jun 25, Jeff-Chew commented: cc: @kenny-lam @vladislav-saling @hahnrob @linda-carotenuto @Wonil-Suh1 |
On Jun 25, james-dow commented:
In relation to Drupal, I haven't been a part of those discussions so I'm not totally looped into the requirements. But I am curious why Drupal wouldn't just use the given component/pattern's documentation page on the website? I'm a little confused why they would be special enough to warrant their own documentation site like Storybook. Looping in @chsanche too. |
On Jun 25, Jeff-Chew commented:
They don't want pattern lab, per se, but the underlying twig/json templates which they can reference directly in our packages. So theoretically, we wouldn't have to do this in pattern lab but whatever automated template documentation we wish to use (storybook, fractal, pattern lab, etc). However, we wouldn't have a way for us to visually test if we are creating twig templates, unless we have something like pattern lab's twig php engine. Which is the problem I described above. I'd love to find a way to use something more modern like Storybook. It gives us niceties like knobs, storyshots, etc. But I'm struggling with the Drupal request. cc: @hahnrob @Wonil-Suh1 @kenny-lam @linda-carotenuto |
On Jun 26, Jeff-Chew commented: |
On Jun 26, james-dow commented: This part here I understand and get. I'm not trying to say I don't see value in something like a Storybook for testing and live documentation purposes. I do wonder if we could make the website live documentation, but that's probably a little larger effort.
What I don't understand is the following. I don't understand how storybook or even pattern lab solves these problems/requirements that they have.
Couldn't we just push a twig template library to Packagist using Composer with a twig template and its corresponding JSON data file? (I'm really curious learning more about this data file requirement, and how it works). Then Drupal could just use the documentation on the joined gatsby website we build. I'm struggling with why they (Drupal team) would need patterns lab or storybook. Maybe I don't fully understand storybook, and pattern lab's full capabilities, but I thought they just kind of automated creating that live documentation you were talking about, and creates a nice environment to manually test the components. I feel like there is a disconnect with me personally here. I'm not sure if I'm missing some piece of the requirement that ties the two together, or if I'm missing some sort of limitation whether with our site, Storybook/Patternlab, or PHP in general. |
On Jun 26, Jeff-Chew commented: What they asked for and need is a place to directly reference twig templates, where they would want us to provide those and they reference directly from our packages (and not from pattern lab, storybook, fractal, or any other automated templating tool). Before the meeting with their team, I already added a topic in our morning huddle to talk more about this. |
On Jun 26, vladislav-saling commented: IIRC @kenny-lam was the closes to Drupal team earlier this year so he might have some extra insight. |
On Jul 09, Jeff-Chew commented: |
On Jul 17, Jeff-Chew commented: |
On Oct 03, Jeff-Chew commented: |
On Oct 03, linda-carotenuto commented: |
Moving some of `peerDependencies` to `dependencies` for misc dependencies. This reduces some workload when setting up an application using `carbon-custom-elements` library. Fixes carbon-design-system#224.
Moving some of `peerDependencies` to `dependencies` for misc dependencies. This reduces some workload when setting up an application using `carbon-custom-elements` library. Fixes #224.
Jeff-Chew created the following on May 23:
Overview
This is the creation of the package architecture for the Components (VanillaJS/HTML flavor). This will include all IBM.com related components.
Additional Information
carbon-components
to see what architecture can be lifted from thereAcceptance criteria
styles
package for CSS stylingOriginal issue: https://github.ibm.com/webstandards/digital-design/issues/860
The text was updated successfully, but these errors were encountered: