Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use @carbon/icons@10.8.0-rc.0 #6

Merged
merged 1 commit into from
Dec 14, 2019
Merged

refactor: use @carbon/icons@10.8.0-rc.0 #6

merged 1 commit into from
Dec 14, 2019

Conversation

metonym
Copy link
Collaborator

@metonym metonym commented Dec 14, 2019

Closes #5

NOTE: Wait until @carbon/icons@10.8.0 is stable before merging. Release as 10.8.0-rc.0.

Changes

  • Use build-info.json from @carbon/icons@10.8.0-rc.0 to generate icons
  • Use moduleName from build-info.json (removes format.ts)
  • Format template strings to avoid running prettier on written files
  • Remove build:format-lib script
    • Cull devDependencies (npm-run-all, prettier-plugin-svelte, svelte)

Remove devDeps: npm-run-all, prettier-plugin-svelte, svelte.
@metonym metonym added the enhancement New feature or request label Dec 14, 2019
@metonym metonym self-assigned this Dec 14, 2019
@codecov
Copy link

codecov bot commented Dec 14, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@15443ac). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #6   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      1           
  Lines             ?      7           
  Branches          ?      0           
=======================================
  Hits              ?      7           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/template.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15443ac...b05a167. Read the comment docs.

@metonym metonym changed the title (DO NOT MERGE) refactor: use @carbon/icons@10.8.0-rc.0 refactor: use @carbon/icons@10.8.0-rc.0 Dec 14, 2019
@metonym metonym merged commit 7dec404 into master Dec 14, 2019
@metonym metonym deleted the refactor branch December 14, 2019 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: use @carbon/icons build info when available
1 participant