Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): custom element already defined on hmr #133

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Apr 18, 2024

Getting an error when making changes to a component and hot reloading in storybook where it says the component is already defined.

Screenshot 2024-04-18 at 6 43 09 PM (9)

bumping storybook down to v7 seems to resolve the issue. So undoing #102 until we figure out the issue with storybook and hot reloading.

Changelog

Changed

  • bump storybook packages down to v7

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for carbon-labs ready!

Name Link
🔨 Latest commit cb9c91d
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs/deploys/66213950edceec000755d92e
😎 Deploy Preview https://deploy-preview-133--carbon-labs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annawen1 annawen1 merged commit 2f83f6f into carbon-design-system:main Apr 18, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant