Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(utilities): create utilities package #41

Merged

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Dec 4, 2023

Closes #

Create a utilities package that hosts needed files / utils shared amongst the packages. I've added the settings file that sets the prefix throughout the components in each package.

Changelog

New

  • @carbon/ai-utilities package that will house common utils amongst the packages
  • Added settings file that sets the prefixes to the @carbon/ai-utilities package
  • Add dependency to the @carbon/ai-utilities package in all the component packages' package.json
  • build step for the utilities package added to the root build script

Changed

  • set components to get prefix value from the @carbon/ai-utilities package instead of hardcoding

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for carbon-for-ai ready!

Name Link
🔨 Latest commit 1a34710
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ai/deploys/656e36d677e4870008194f6e
😎 Deploy Preview https://deploy-preview-41--carbon-for-ai.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annawen1 annawen1 closed this Dec 4, 2023
@annawen1 annawen1 reopened this Dec 4, 2023
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SWEEET! LGTM

@annawen1 annawen1 merged commit 1efae7e into carbon-design-system:main Dec 5, 2023
8 checks passed
@annawen1 annawen1 deleted the chore/utilities-package branch December 5, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants