Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): improvements and fixes for feedback container #86

Merged
merged 10 commits into from
Mar 13, 2024
Merged

feat(feedback): improvements and fixes for feedback container #86

merged 10 commits into from
Mar 13, 2024

Conversation

priyanshu891
Copy link
Contributor

Closes #

Updated feedback component which now able to visualise the feedback given on text.

Changelog

  • Visualisation of feedback
  • Fixed bug related to feedback flag

Changed

  • Feedback component is standalone component with separate package.

Removed

  • N/A

Testing / Reviewing

{{ Add descriptions, steps or a checklist for how reviewers can verify this PR works or not }}

Copy link
Contributor

github-actions bot commented Feb 27, 2024

DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


2 out of 3 committers have signed the DCO.
@priyanshu891
@annawen1
@priyanshu Rai
Priyanshu Rai seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@priyanshu891
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@priyanshu891
Copy link
Contributor Author

recheck

@priyanshu891
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@priyanshu891
Copy link
Contributor Author

recheck

.gitignore Show resolved Hide resolved
@annawen1
Copy link
Member

I see the Netlify build for the deploy preview is failing due to these errors
Screenshot 2024-02-27 at 9 39 22 AM

packages/chat/index.ts Outdated Show resolved Hide resolved
@carbon-design-system carbon-design-system deleted a comment from netlify bot Mar 1, 2024
@annawen1 annawen1 merged commit 32b0849 into carbon-design-system:main Mar 13, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants