refactor(interior-left-nav): Update to 7.x #33
Conversation
|
Lots of ESLint errors |
|
👍 ✅ ❗️ |
|
Linting is failing! but besides that it looks good 👍 |
|
👍 ✅ |
| @@ -183,3 +183,4 @@ module.exports = function (config) { | |||
| concurrency: Infinity, | |||
| }); | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
No change to this file seems necessary.
| @@ -136,3 +136,4 @@ module.exports = function (config) { | |||
| concurrency: Infinity, | |||
| }); | |||
| }; | |||
|
|
|||
There was a problem hiding this comment.
No change to this file seems necessary.
| this.element.dataset.collapsed = true; | ||
| this.element.classList.add(this.options.classLeftNavCollapsing); | ||
|
|
||
| window.setTimeout( |
There was a problem hiding this comment.
No window prefix is necessary.
There was a problem hiding this comment.
The timer should be cancelled when user expands/collapses again. Otherwise the code introduces possibility of race condition (note that the timeout duration is approximate, not guaranteed).
| this.element.classList.remove(this.options.classLeftNavCollapsed); | ||
| this.element.classList.add(this.options.classLeftNavExpanding); | ||
|
|
||
| window.setTimeout( |
There was a problem hiding this comment.
No window prefix is necessary.
There was a problem hiding this comment.
The timer should be cancelled when user expands/collapses again. Otherwise the code introduces possibility of race condition (note that the timeout duration is approximate, not guaranteed).
Remove an out of date ref to addon-info
* chore: sync offline mirror * feat(grid): add grid package * chore: sync offline mirror
feat: add icon library component
Overview
Resolves https://github.ibm.com/Bluemix/bluemix-components/issues/2112
Updated the interior left nav as it was the 6.x version (and the 7.x version was in the v6 release).
Changed
Changed all occurrences of
inline-left-navtointerior-left-nav.