-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data-table): sortable, boolean column, and overflow menu row fixes #6268
fix(data-table): sortable, boolean column, and overflow menu row fixes #6268
Conversation
Deploy preview for carbon-elements ready! Built with commit a523eb7 |
Deploy preview for carbon-components-react ready! Built with commit a523eb7 https://deploy-preview-6268--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great to me ! thank you 🙌🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great after TJ's feedback 👀
just a heads up, the Safari issue is an unresolved flexbox issue at the browser level compare this demo in different browsers: https://codesandbox.io/s/funny-golick-u5zfe a workaround is to add a wrapper element around the table header content, but then we will need to adjust table styles across the board accordingly. if that's fine I can proceed with that plan related links https://codepen.io/scheinercc/pen/ZEGwpKb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emyarod I'm fine with it as is if it's a browser level issue, and it's only appearing on a very specific scenario (tall table with a mix of sortable headers, only on safari).
Thanks for the links!
I have the fix prepared if you want to take a look, but if we don't want to go forward with it I can just revert the latest commits |
6a46000
to
cab0e5e
Compare
@emyarod ah gotcha, let me check it out |
Nice! Looks like its rendering properly across all browsers. Didn't realize adding a span inside the button would get around the flex inconsistencies in buttons. |
d58ccac
to
a523eb7
Compare
Closes #6261
Closes #6262
This PR addresses data table issues specific to the boolean column, overflow menu, and sortable variants.
Testing / Reviewing
The row heights for all variants should be consistent with the headers, and the alignment and positioning of table elements should be consistent with the spec