-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add remarkPlugins theme option #821
feat: add remarkPlugins theme option #821
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/8edxfvzz8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for this, we don't use remark plugins in our sites so aren't exposed to the issues. Maybe you could add a note for when someone might use one or the other? Even a "if this doesn't work, try this" sort of note.
Just don't want folks to look at gatsbyRemarkPlugins
and remarkPlugins
and not know which to reach for.
Thanks. I added this to the documentation:
Hopefully this wording is good enough to explain the difference? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant fixes, thank you again!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Brilliant! Love the clarity you brought to that section of the docs.
Add a
remarkPlugins
option to pass along togatsby-plugin-mdx
.The reason this is required in addition to the
gatsbyRemarkPlugins
option is becausegatsbyRemarkPlugins
has had numerous issues with getting plugins to work with it:But the
remarkPlugins
option works great and is usually the workaround that is eventually used. So exposing this option to the user helps.Changelog
New
remarkPlugins
theme option to be passed togatsby-plugin-mdx
remark-grid-tables
remark plugin