-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release script changes & changelog 0.14.0 #1181
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionThis is using ada-only outputs for better comparability.
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
End-To-End Benchmark ResultsThis page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes. Generated at 2023-12-04 14:46:01.933811217 UTC Baseline Scenario
Baseline Scenario
|
31c723e
to
e5f514a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left some suggested changes as it seems the script fail on my machine because of discrepancies in extensions handling in sed
.
Rather than an interactive script, I think I would prefer a script that can run automatically given arguments, with a pre-flight checks logic ensuring no changes are made if arguments are invalid. this would make it easier to port it to a CI workflow.
@@ -117,28 +147,28 @@ update_cabal_version() { | |||
|
|||
for file in $cabal_files | |||
do | |||
sed -i.bak -e "s,\(^version: *\)[^ ]*,\1$version," $file | |||
sed -i"" -e "s,\(^version: *\)[^ ]*,\1$version," $file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-i""
is expanded into -i
, eg. a single argument and not -i ""
eg. passing empty string to -i
which leads to backup files named xxx-e
:)
sed -i"" -e "s,\(^version: *\)[^ ]*,\1$version," $file | |
sed -i "" -e "s,\(^version: *\)[^ ]*,\1$version," $file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My man sed
says -i
is a FreeBSD extension so not sure if it works the same in GNU version.
done | ||
} | ||
|
||
update_api_version() { | ||
local version="$1" ; shift | ||
local api_file=hydra-node/json-schemas/api.yaml | ||
|
||
sed -i.bak -e "s,\(version: *\)'.*',\1'$version'," $api_file | ||
sed -i"" -e "s,\(version: *\)'.*',\1'$version'," $api_file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
sed -i"" -e "s,\(version: *\)'.*',\1'$version'," $api_file | |
sed -i "" -e "s,\(version: *\)'.*',\1'$version'," $api_file |
release.sh
Outdated
} | ||
|
||
update_tutorial_version() { | ||
local version="$1" | ||
local tutorial_file=docs/docs/tutorial/index.md | ||
sed -i.bak -e "s,\(hydra/releases/download/)[^/]*,\1$version," $tutorial_file | ||
sed -i"" -e "s,\(hydra/releases/download/\)[^/]*,\1$version," $tutorial_file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
sed -i"" -e "s,\(hydra/releases/download/\)[^/]*,\1$version," $tutorial_file | |
sed -i "" -e "s,\(hydra/releases/download/\)[^/]*,\1$version," $tutorial_file |
} | ||
|
||
update_demo_version() { | ||
local version="$1" | ||
( | ||
cd demo | ||
sed -i.bak -e "s,\(ghcr.io/input-output-hk/hydra-[^:]*\):[^[:space:]]*,\1:$version," docker-compose.yaml seed-devnet.sh | ||
sed -i"" -e "s,\(ghcr.io/input-output-hk/hydra-[^:]*\):[^[:space:]]*,\1:$version," docker-compose.yaml seed-devnet.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
sed -i"" -e "s,\(ghcr.io/input-output-hk/hydra-[^:]*\):[^[:space:]]*,\1:$version," docker-compose.yaml seed-devnet.sh | |
sed -i "" -e "s,\(ghcr.io/input-output-hk/hydra-[^:]*\):[^[:space:]]*,\1:$version," docker-compose.yaml seed-devnet.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the release script on my machine and it works 👍
b500377
to
300b12d
Compare
This file is expected to hold transaction ids for released Hydra versions. As such we can use it to make the tutorial simpler to be kept up-to-date.
33483ed
to
22e91bc
Compare
Fixed and refined
release.sh
script to work for 0.14.0Also cleaned up the changelog and added links to issues