-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix /protocol-parameters JSON response #1241
Conversation
Transactions CostsSizes and execution budgets for Hydra protocol transactions. Note that unlisted parameters are currently using
Script summary
Cost of Init Transaction
Cost of Commit TransactionThis is using ada-only outputs for better comparability.
Cost of CollectCom Transaction
Cost of Close Transaction
Cost of Contest Transaction
Cost of Abort TransactionSome variation because of random mixture of still initial and already committed outputs.
Cost of FanOut TransactionInvolves spending head output and burning head tokens. Uses ada-only UTxO for better comparability.
End-To-End Benchmark ResultsThis page is intended to collect the latest end-to-end benchmarks results produced by Hydra's Continuous Integration system from the latest Please take those results with a grain of salt as they are currently produced from very limited cloud VMs and not controlled hardware. Instead of focusing on the absolute results, the emphasis should be on relative results, eg. how the timings for a scenario evolve as the code changes. Generated at 2024-01-09 17:13:02.039092048 UTC Baseline Scenario
Baseline Scenario
|
12069b5
to
b0fbf51
Compare
Test Results401 tests +8 394 ✅ +9 17m 16s ⏱️ - 1m 53s Results for commit 9c13146. ± Comparison against base commit 3c8f217. This pull request removes 1 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
Draft a test which checks the schema of the /protocol-parameters endpoint response using a re-usable validateJSON function. The function signature is kept similar to [openapi3](https://hackage.haskell.org/package/openapi3-3.2.4/docs/Data-OpenApi-Schema-Validation.html#v:validateJSON) to allow migration to an openapi 'Schema' later.
We need to copy the schema files correctly into the temporary working directory of validateJSON.
This reverts commit fcb02e1.
This is the one implemented by cardano-cli and the same format the hydra-node expects on the command line.
This matches now what we also accept on the command line and what the cardano-cli is giving us.
This allows us to re-use this functionality from hydra-cluster tests, while still using package-specific functionality from hydra-node (accessing schema files) and avoids moving this into the production code base.
This test suite is now also running check-jsonschema and hence needs this binary available.
1498149
to
b2061f0
Compare
b2061f0
to
9c13146
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great one! 👏
Fixes a regression where usage of the ledger
PParams
would change the schema available on/protocol-parameters
endpoing.Adds "our" JSON schema for
ProtocolParameters
as the one from https://github.com/CardanoSolutions/cardanonical (currently) does not matchAdd tests for schema conformance of
/protocol-parameters
Add test of schema conformance of
cardano-cli query protocol-parameters
Move
JSONSchema
utility into new public sub-library ofhydra-node
to re-use it everywhere and.Creates a new
validateJSON
utility function inJSONSchema
module to do directed schema tests. See thehydra-cluster
changes, which would produce with an intentionally wrong schema: