-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recording and Web enhancement #96
Conversation
At 100% height we have full page scroll + panel scroll
… don't want to include in potentially dynamic RN vs web client
npm install @nrwl/nx-cloud && npx nx g @nrwl/nx-cloud:init
npm install -D @jscutlery/semver nx g @jscutlery/semver:install
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 17211de. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
|
||
Run `npm publish dist/libs/core --access public` from the root of the project. | ||
Run `npm publish dist/libs/core --access public` from the root of the project, but CI will push it all when a release is made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"but CI will push it" by "push it" you mean it will bump it when a release is made?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gonzalo8642 if you have my npm token you can push directly to npm locally, but in github if you create a release it will run the CI job to push. Bumping the version isn't currently possible via CI/CD. So workflow is
- Run script locally to bump version
- Push the tag created by that command to upstream
- Create release on github.com which will trigger npm publish
|
||
Run `npm publish dist/libs/core --access public` from the root of the project. | ||
This repo uses conventional commits, an easy interactive way to stay compliant is to run `npm run commit` or `git cz` when committing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will it prevent people from committing unless they use git cz
? I don't see a pre commit hook. Would be nice to have all commits aligned. I guess I can test this after I merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gonzalo8642 it should be there unless it was only setup on my machine (it blocked me from committing using husky i believe). Give it a try now that it's merged in and let me know
React Native intercepting supported
Run this once and all network requests from the JS layer will be captured.
(Note all required libraries are not yet published to npm, until then this only works if locally adding dependencies)
React Native as a Reactotron plugin supported
In this way both the Mezzo web GUI and the Reactotron app will receive API data. Otherwise if you wanted both whomever registered for the intercepts last was taking control, and since mezzo intercept logic is based off reactotron code was 90% identical anyways and did some heavy operations 2x (such as parsing every API payload). In this way all the parsing and intercepting logic happens once, but then it is sent to 2 places (Mezzo and Reactotron servers).
Closes #97
Non-monkey patch fetch supported
You will have to call this in place of every
fetch
as it simply wraps the network call, it doesn't actually rewrite any global behavior.Web dashboard showing network capture supported
Not yet supported
Misc
Conventional commits are now enforced. Based on commit details we can then properly bump versions when it is time to release. Run
npm run commit
orgit cz
when committing for an interactive commit experience, or manually format your commits to conventional commit standards.Closes #36
Implementation details
Closes #94