Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rendering Issues in 0.9.10 #3377

Closed
Kipt opened this issue Sep 29, 2020 · 11 comments
Closed

Rendering Issues in 0.9.10 #3377

Kipt opened this issue Sep 29, 2020 · 11 comments
Assignees
Labels
stale Issue has not had recent activity

Comments

@Kipt
Copy link

Kipt commented Sep 29, 2020

I decided to try out 0.9.10 and I noticed the colors seemed way too bright. After more investigation I also noticed severe glitches regarding reflections on water. By the looks of it the raycasting is failing horribly, causing black dots to appear.

The easiest way to see this is by setting weather to 'HardRainSunset' and looking at the reflections of the sun.

I'm running Carla through docker with -opengl flag (without it I get a crash). I've tried using both x11 and offscreen as SDL_VIDEODRIVER but no difference.

Full command is docker run -e SDL_VIDEODRIVER=offscreen -it -p 2000-2002:2000-2002 --gpus all carlasim/carla:0.9.10 /bin/bash ./CarlaUE4.sh -opengl.

The glitches are visible with spectator as well as through the sensors.

Tested with
Ubuntu 18.04.5
GeForce RTX 2080 Ti
nvidia-driver-450

Carla_0 9 10

@Kipt
Copy link
Author

Kipt commented Sep 29, 2020

As a comparison, this is 0.9.9 version:
Carla_0 9 9

@XGodina
Copy link
Contributor

XGodina commented Sep 29, 2020

Hello @Kipt ,

We by default use Vulkan and the lighting values are set to this one.
I don't know if that affects the docker. @bernatx can you help us with Docker?

@p-testolina
Copy link

Hi guys,
I noticed the same brightness problem on 0.9.10 and 0.9.10.1 (tested this morning!). I'm running the docker image via singularity, and it's working fine without the -opengl flag, but the scenes seem way too bright. Same setup as @Kipt

@XGodina
Copy link
Contributor

XGodina commented Oct 1, 2020

Hi, @p-testolina,
Can you provide some images? Wich Town you tested?

@p-testolina
Copy link

p-testolina commented Oct 1, 2020

Hi @XGodina, thanks for the quick reply.
I tested the same weather settings using the dynamic_weather.py example using Town03. I hope I got them right.

This is what I get from the spectator with 0.9.9
0 9 9
and with 0.9.10
0 9 10
I didn't have the time to check the camera acquisitions yet. I can produce them if you need them.

Looks similar to what @Kipt reported. I'm running the simulator without the --opengl flag.

@Madecu
Copy link
Contributor

Madecu commented Oct 2, 2020

Hi @p-testolina,
In the new 0.9.10, we have changed the exposure mode of the camera to auto exposure and we have tweaked the camera configuration a little bit. That is why the image is now brighter than before.
We have exposed a lot of parameters so you can customize your RGB camera the same way you would in real life. You can set your camera (the RGB sensor of the car or the Spectator camera from unreal) with your customize ISO, aperture, shutter speed, and more advanced configurations. Check out the documentation, we listed all the parameters for the RGB sensors:
https://carla.readthedocs.io/en/latest/ref_sensors/#rgb-camera

Regarding the issue @Kipt has with those black reflections, we are aware of that. It only happens on Linux with OpenGL. We are working on that. We can also try to solve why it crashes if you use Vulkan instead, so you don't have to use the opengl flag. OpenGL doesn't support other features such as mesh distance fields, so it would be better to use vulkan if you can.

@Kipt
Copy link
Author

Kipt commented Oct 5, 2020

@Madecu The output I get when running through docker is

docker run --rm -e SDL_VIDEODRIVER=x11 -e DISPLAY=$DISPLAY -v /tmp/.X11-unix:/tmp/.X11-unix -it -p 2000-2003:2000-2003 --gpus all carlasim/carla:0.9.10 /bin/bash ./CarlaUE4.sh -world-port 2000
4.24.3-0+++UE4+Release-4.24 518 0
Disabling core dumps.
sh: 1: xdg-user-dir: not found
LowLevelFatalError [File:Unknown] [Line: 772] 
VulkanRHI::vkGetPhysicalDeviceSurfaceFormatsKHR(Device.GetPhysicalHandle(), Surface, &NumFormats, nullptr) failed, VkResult=-3
 at /home/jenkins/UnrealEngine_4.24/Engine/Source/Runtime/VulkanRHI/Private/VulkanSwapChain.cpp:152 
 with error VK_ERROR_INITIALIZATION_FAILED
Signal 11 caught.
Malloc Size=65538 LargeMemoryPoolOffset=65554 
CommonUnixCrashHandler: Signal=11
Malloc Size=65535 LargeMemoryPoolOffset=131119 
Malloc Size=93152 LargeMemoryPoolOffset=224288 
Engine crash handling finished; re-raising signal 11 for the default handler. Good bye.

Docker version is 19.03.13 and I can run vulkaninfo on the host indicating it should support vulkan.

@Kipt
Copy link
Author

Kipt commented Oct 5, 2020

It seems adding some parameters to docker fixed the issue. With --gpus 'all,"capabilities=graphics,utility,display,video,compute"' it runs with Vulkan resulting in the below image. Still quite brighter than the 0.9.9 spectator camera but as the brightness can be modified in the camera sensors it's a minor detail.

I suggest adding a note in the documentation https://carla.readthedocs.io/en/latest/build_docker/.

Thank you for your help, feel free to close if the above docker parameter looks correct.

Carla_0_9_10_Vulkan

@XGodina
Copy link
Contributor

XGodina commented Oct 5, 2020

Hi, @Kipt
Thank you for your input

@stale
Copy link

stale bot commented Dec 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had recent activity label Dec 13, 2020
@stale stale bot closed this as completed Dec 25, 2020
@qhaas
Copy link
Contributor

qhaas commented Jan 25, 2021

Seeing this issue in CARLA 0.9.11 with opengl (headless, with no x-server is a requirement), bare-metal (i.e. no container) in Ubuntu 20.04 with opengl on a dgx a100 under certain weather conditions (e.g. HardRainSunset). It does not show up in the semantic segmentation camera. This doesn't seem to happen on CARLA 0.9.8 likely because of the older UnrealEngine(?).
0_9_11_opengl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue has not had recent activity
Projects
None yet
Development

No branches or pull requests

6 participants