Apprise HTML/MARKDOWN/TEXT Translation Handling Refactoring #575
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): #573
This really all ties back to #565 (and PR #566); This was a rather destructive event unfortunately that i was not prepared for.
I spent all day today debugging it and made some progress (still a ways to go). I may just revert at some point, but i'd like to see if i can iron this out and make some sense out of the HTML/TEXT/MARKDOWN inter-conversions a bit better.
This also addresses all comments made in: #577, #576, #572.
It continues onto PR #574 and unfortunately all stems back to #565 which blew up Apprise attempting to accommodate it. 😲
I'm hoping I've almost nailed this all now in this release. I tested it with Mail and resigned in with my Telegram account as well to verify how things looked there. So far so good.
The biggest change here, is that after all this, the default Telegram Posting is in HTML now not TEXT. One sure-fire-way to roll back would be to just switch it back to TEXT. But i think it would be great to correctly support all formats and all the transitions between them. Telegram proved to be a pain only because while it accepts HTML, it's so restrictive that there is a lot of extra leg-work to convert True HTML -> Telegram HTML.
Please let me know if this works for people; the instructions to test this are below. If we're satisfied i'll push another Apprise release ASAP and fix this once and for all.
Checklist
flake8
)Testing
Anyone can help test this source code as follows: