Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSyslog added (split from syslog://) Service #930

Merged
merged 1 commit into from
Aug 20, 2023
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented Aug 20, 2023

Description:

Related issue (if applicable): #

Syslog and RSyslog broken into 2 individual services allowing users of Apprise-API and other individuals to decouple what is considered a local service and what can allow for remote use.

New Service Completion Status

  • apprise/plugins/NotifyRSyslog.py
  • KEYWORDS
    • add new service into this file (alphabetically).
  • README.md
    • add entry for new service to table (as a quick reference)
  • packaging/redhat/python-apprise.spec
    • add new service into the %global common_description

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@syslog-rsyslog-split

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "rsyslog://remote.server/user/"

@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (f55032a) 99.52% compared to head (3ea5ff5) 99.52%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #930   +/-   ##
=======================================
  Coverage   99.52%   99.52%           
=======================================
  Files         122      123    +1     
  Lines       16250    16328   +78     
  Branches     3321     3327    +6     
=======================================
+ Hits        16173    16251   +78     
  Misses         68       68           
  Partials        9        9           
Files Changed Coverage Δ
apprise/plugins/NotifyRSyslog.py 100.00% <100.00%> (ø)
apprise/plugins/NotifySyslog.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit e46f8fe into master Aug 20, 2023
12 checks passed
@caronc caronc deleted the syslog-rsyslog-split branch August 20, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants