-
-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits for neutral point of view in truthy/falsy #43
Conversation
I know I cannot speak for everyone, but I was unaware of what "Boolean" meant until I was in grad school. What do you think about simplifying the definitions (truthy: "evaluates to true" or "colloquially thought to be true") and/or define boolean as well. |
@zkamvar Updated to add a Boolean definition and associated references. |
glossary.yml
Outdated
@@ -592,9 +602,10 @@ | |||
en: | |||
term: "falsy" | |||
def: > | |||
A horrible neologism meaning "equivalent to false". | |||
Evaluating to false in a Boolean context. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Evaluating to false in a Boolean context. | |
Evaluating to false in a [Boolean](#boolean) context. |
Thank you! I have one more suggestion for cross-linking, purposes, but that should be it! (you can safely ignore the lint error, that should be fixed in another PR). |
A few more definitions to round out Boolean for explaining truthy/falsy
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
@zkamvar I've added a few more deffinitions to build-out the thread of boolean logic. Still more to add in the future though, bytes, kilobytes, megabytes... etc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I made some edits to include internal links and streamline the language between definitions. IMO, it may have been overkill to define "true" and "false", but the more the merrier 👍
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
How fun! I approve the merge, yet I'm not a maintainer 😅 @gvwilson, @fmichonneau @ian-flores, do any of you have access to merge this? |
I think @zkamvar should be a maintainer - @fmichonneau ? |
thank you all! |
Per #29 updating truthy/falsy definitions to be neutral in their point of view.
Author:
Language:
Terms defined:
None
Editor
Assign the PR based on the language to the following person: