Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits for neutral point of view in truthy/falsy #43

Merged
merged 14 commits into from
Aug 5, 2020
Merged

Edits for neutral point of view in truthy/falsy #43

merged 14 commits into from
Aug 5, 2020

Conversation

jduckles
Copy link
Contributor

@jduckles jduckles commented Aug 4, 2020

Per #29 updating truthy/falsy definitions to be neutral in their point of view.

Author:

  • Jonah Duckles

Language:

  • English

Terms defined:

None

Editor

Assign the PR based on the language to the following person:

Language Person
English @zkamvar
Spanish @ian-flores
French @fmichonneau

@zkamvar
Copy link
Contributor

zkamvar commented Aug 4, 2020

I know I cannot speak for everyone, but I was unaware of what "Boolean" meant until I was in grad school. What do you think about simplifying the definitions (truthy: "evaluates to true" or "colloquially thought to be true") and/or define boolean as well.

@jduckles
Copy link
Contributor Author

jduckles commented Aug 4, 2020

@zkamvar Updated to add a Boolean definition and associated references.

glossary.yml Outdated
@@ -592,9 +602,10 @@
en:
term: "falsy"
def: >
A horrible neologism meaning "equivalent to false".
Evaluating to false in a Boolean context.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Evaluating to false in a Boolean context.
Evaluating to false in a [Boolean](#boolean) context.

glossary.yml Outdated Show resolved Hide resolved
@zkamvar
Copy link
Contributor

zkamvar commented Aug 4, 2020

Thank you! I have one more suggestion for cross-linking, purposes, but that should be it! (you can safely ignore the lint error, that should be fixed in another PR).

jduckles and others added 2 commits August 5, 2020 08:58
A few more definitions to round out Boolean for explaining truthy/falsy
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
@jduckles
Copy link
Contributor Author

jduckles commented Aug 4, 2020

@zkamvar I've added a few more deffinitions to build-out the thread of boolean logic. Still more to add in the future though, bytes, kilobytes, megabytes... etc.

Copy link
Contributor

@zkamvar zkamvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I made some edits to include internal links and streamline the language between definitions. IMO, it may have been overkill to define "true" and "false", but the more the merrier 👍

glossary.yml Outdated Show resolved Hide resolved
glossary.yml Outdated Show resolved Hide resolved
glossary.yml Outdated Show resolved Hide resolved
glossary.yml Outdated Show resolved Hide resolved
glossary.yml Outdated Show resolved Hide resolved
glossary.yml Outdated Show resolved Hide resolved
glossary.yml Outdated Show resolved Hide resolved
glossary.yml Outdated Show resolved Hide resolved
jduckles and others added 8 commits August 5, 2020 09:28
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
Co-authored-by: Zhian N. Kamvar <zkamvar@gmail.com>
@zkamvar
Copy link
Contributor

zkamvar commented Aug 4, 2020

How fun! I approve the merge, yet I'm not a maintainer 😅 @gvwilson, @fmichonneau @ian-flores, do any of you have access to merge this?

@gvwilson
Copy link
Contributor

gvwilson commented Aug 4, 2020

I think @zkamvar should be a maintainer - @fmichonneau ?

@fmichonneau
Copy link
Contributor

thank you all!
there were a few issues with the formatting of the yaml file that I fixed.
@zkamvar (as well as @gvwilson and @ian-flores) are now "admin" on all 3 glosario-related repos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants