Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the enforcer file code doc to complete #8

Merged
merged 2 commits into from
Aug 9, 2018
Merged

Update the enforcer file code doc to complete #8

merged 2 commits into from
Aug 9, 2018

Conversation

nodece
Copy link
Member

@nodece nodece commented Aug 9, 2018

No description provided.

@coveralls
Copy link

coveralls commented Aug 9, 2018

Pull Request Test Coverage Report for Build 21

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 48.299%

Files with Coverage Reduction New Missed Lines %
src/enforcer.ts 1 34.46%
Totals Coverage Status
Change from base Build 18: 0.0%
Covered Lines: 432
Relevant Lines: 822

💛 - Coveralls

Copy link
Member

@hsluoyz hsluoyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify these commits.

src/enforcer.ts Outdated
// See the License for the specific language governing permissions and
// limitations under the License.

/**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this license header should be updated for all source files together at once. It should not be updated for only one file. Please remove this change.

@hsluoyz hsluoyz merged commit b627d77 into casbin:master Aug 9, 2018
nodece pushed a commit to nodece/node-casbin that referenced this pull request Mar 27, 2023
Signed-off-by: Shivansh-yadav13 <yadavshivansh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants