Ont 251 #41
Merged
Ont 251 #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds Makefiles that confirm CASE ontology Turtle files are
normalized according to the command specified in NORMALIZING.md.
Usage:
* `make` - does nothing. Nothing in the ontology currently depends on
executing code to build a component.
* `make check` - downloads `rdf-toolkit.jar` to the `/lib` directory in
this repository, if not already present, and checks that ontology
files match the output of `rdf-toolkit.jar` running against them.
- `make check`, or `make .lib.done.log`, needs to be called in the
root directory of this repository at least once. After that,
`make check` will work in any directory at or under `/ontology`.
The hash of `rdf-toolkit.jar` will be recorded in the Git history in the
next commit, with a timestamp indicating when I first encountered this
hash.
This patch begins a resolution of ONT-251.
References:
* [ONT-251] Establish unit tests, possibly Continuous Integration, for
ontology repository
Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
The timestamp of this hash is copied from my first record of the hash published in the CASE-Examples-QC repository [1]. This is a "Trust on first use"---aka "TOFU" [1]---record, and makes no assertions on qualities of the file aside from this being the hash I recorded on first downloading it. References: [1] https://github.com/ajnelson-nist/CASE-Examples-QC/ [2] https://en.wikipedia.org/wiki/Trust_on_first_use Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This was tested by deleting the jar file and running `make clean && make && make check` from the repository root. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This encodes `make check` as the mechanism for running tests. Tests are as specified in NORMALIZE.md. References: * [ONT-251] (CP-16) Establish unit tests, possibly Continuous Integration, for ontology repository Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This workflow file was started as a copy of the CASE website repository's CI script. I forgot to update the name. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This ports a change tested in the CASE-Examples-QC repository: ajnelson-nist/CASE-Examples-QC#1 References: * [ONT-383] Find alternative retrieval point for rdf-toolkit.jar Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
One of the maintainers on the rdf-toolkit Github repository had committed the built jar we were using into another repository. I confirmed that the SHA-512 of this file matches what was recorded in the CASE repository. This patch implements a fallback download pattern, favoring downloading from Github, and then from files.caseontology.org. References: * [ONT-383] Find alternative retrieval point for rdf-toolkit.jar Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
References: * [ONT-251] (CP-16) Establish unit tests, possibly Continuous Integration, for ontology repository A link to the proposal file will be added to ChangeLog before the CASE 0.3.0 release. Signed-off-by: Alex Nelson <alexander.nelson@nist.gov>
This address conflicts in the Changelog file.
|
We seem to have a configuration error where I can't review this PR. Please consider this PR passing my review, and merge when you are ready, @plbt5 . |
plbt5
approved these changes
Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.